Remove Regexp 'General Category' classes for windows#566
Remove Regexp 'General Category' classes for windows#566MSP-Greg wants to merge 1 commit intoruby:masterfrom
Conversation
MSP-Greg
changed the title
|
Please do not accept this PR. I investigated further, it is really a Ruby / Windows encoding issue that goes back to at least Ruby 2.0. I submitted PR evanphx/kpeg#37 for it. Since the code that affects the running kpeg gem is minimal, I added a commit MSP-Greg@d89e07b to my rdoc fork that applies the patch before testing (assumes kpeg v1.1.0). The Appveyor results pass for ruby 2.2 thru trunk. Note that the results without the change fail for all versions. If anyone is interested (I'm aware this just affects building the gem on windows, not installing or using it), I'm not sure if it works for windows users who are not using the default encoding of IBM437... Thanks, Greg |
|
OK, I got the picture and thank you for your detailed investigation. I wait for that KPeg's issue is resolved by that the Pull Request is merged. |
2 participants
See Ruby Core issue 14137.
I checked
\p{Blank}, and it does match 'fractional' Unicode space characters.Before PR, I tested on Appveyor with ruby 2.2 thru trunk, and all failed; last passing test done was at beta2. This PR passed here on Appveyor.
@aycabta Thanks for the PR's over in YARD. I build https://msp-greg.github.io/ daily (or more) with trunk, so I'm catching many of the Ripper changes, as YARD is pretty stable and doesn't have a lot or PR's or commits...